Incorrect include file order in guc-file.l - Mailing list pgsql-hackers

From Michael Paquier
Subject Incorrect include file order in guc-file.l
Date
Msg-id Y2IATvRGo347Lvd1@paquier.xyz
Whole thread Raw
Responses Re: Incorrect include file order in guc-file.l
List pgsql-hackers
Hi all,

While reviewing a different patch, I have noticed that guc-file.l
includes sys/stat.h in the middle of the PG internal headers.  The
usual practice is to have first postgres[_fe].h, followed by the
system headers and finally the internal headers.  That's a nit, but
all the other files do that.

{be,fe}-secure-openssl.c include some exceptions though, as documented
there.

Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: psql: Add command to use extended query protocol
Next
From: Andy Fan
Date:
Subject: Re: A new strategy for pull-up correlated ANY_SUBLINK