Re: Incorrect include file order in guc-file.l - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Incorrect include file order in guc-file.l
Date
Msg-id 20221102060105.o5raimiuo2aopv4r@jrouhaud
Whole thread Raw
In response to Incorrect include file order in guc-file.l  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect include file order in guc-file.l
Re: Incorrect include file order in guc-file.l
List pgsql-hackers
Hi,

On Wed, Nov 02, 2022 at 02:29:50PM +0900, Michael Paquier wrote:
>
> While reviewing a different patch, I have noticed that guc-file.l
> includes sys/stat.h in the middle of the PG internal headers.  The
> usual practice is to have first postgres[_fe].h, followed by the
> system headers and finally the internal headers.  That's a nit, but
> all the other files do that.
>
> {be,fe}-secure-openssl.c include some exceptions though, as documented
> there.

Agreed, it's apparently an oversight in dac048f71eb.  +1 for the patch.



pgsql-hackers by date:

Previous
From: 吴亚飞
Date:
Subject: spinlock support on loongarch64
Next
From: Amit Kapila
Date:
Subject: Re: Improve description of XLOG_RUNNING_XACTS