Some regression tests for the pg_control_*() functions - Mailing list pgsql-hackers

From Michael Paquier
Subject Some regression tests for the pg_control_*() functions
Date
Msg-id Y1d2FZmQmyAhPSRG@paquier.xyz
Whole thread Raw
Responses Re: Some regression tests for the pg_control_*() functions  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Hi all,

As mentioned in [1], there is no regression tests for the SQL control
functions: pg_control_checkpoint, pg_control_recovery,
pg_control_system and pg_control_init.

It would be minimal to check their execution, as of a "SELECT FROM
func()", still some validation can be done on its output as long as
the test is portable enough (needs transparency for wal_level, commit
timestamps, etc.).

Attached is a proposal to provide some coverage.  Some of the checks
could be just removed, like the ones for non-NULL fields, but I have
written out everything to show how much could be done.

Thoughts?

[1]: https://www.postgresql.org/message-id/YzY0iLxNbmaxHpbs@paquier.xyz
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Getting rid of SQLValueFunction
Next
From: Japin Li
Date:
Subject: Re: fixing typo in comment for restriction_is_or_clause