Postgres Pro
Downloads
Home   >   mailing lists

Re: GUC values - recommended way to declare the C variables? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: GUC values - recommended way to declare the C variables?
Date
Msg-id Y0dgHfEGvvay5nle@paquier.xyz
Whole thread Raw
In response to Re: GUC values - recommended way to declare the C variables?  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: GUC values - recommended way to declare the C variables?  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Oct 12, 2022 at 12:12:15PM -0700, Nathan Bossart wrote:
> Looks reasonable to me.  I've marked this as ready-for-committer.

So, the initial values of max_wal_senders and max_replication_slots
became out of sync with their defaults in guc_tables.c.  FWIW, I would
argue the opposite way: rather than removing the initializations, I
would fix and keep them as these references can be useful when
browsing the area of the code related to such GUCs, without having to
look at guc_tables.c for this information.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher