Re: ALTER TABLE uses a bistate but not for toast tables - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: ALTER TABLE uses a bistate but not for toast tables
Date
Msg-id Y0ZkSMJDavVEqn7S@paquier.xyz
Whole thread Raw
In response to Re: ALTER TABLE uses a bistate but not for toast tables  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
List pgsql-hackers
On Wed, Sep 07, 2022 at 10:48:39AM +0200, Drouvot, Bertrand wrote:
> +       if (bistate)
> +       {
> +               table_finish_bulk_insert(toastrel, options); // XXX
>
> I think it's too early, as it looks to me that at this stage we may have not
> finished the whole bulk insert yet.

Yeah, that feels fishy.  Not sure what's the idea behind the XXX
comment, either.  I have marked this patch as RwF, following the lack
of reply.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Tracking last scan time
Next
From: John Naylor
Date:
Subject: Re: meson PGXS compatibility