Repeat the condition check twice in function distribute_qual_to_rels - Mailing list pgsql-hackers

From bigbro_wq@hotmail.com
Subject Repeat the condition check twice in function distribute_qual_to_rels
Date
Msg-id TYCPR01MB6093C42081BD8EC36E03478F85502@TYCPR01MB6093.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: Repeat the condition check twice in function distribute_qual_to_rels
List pgsql-hackers
Hi,
I notice that check the condtion again when after invoked process_equivalence and return failed.

if (restrictinfo->mergeopfamilies)
{
if (maybe_equivalence)
{
if (process_equivalence(root, &restrictinfo, jtitem->jdomain))
{
/* distribute to base  */
int relid;
if (bms_get_singleton_member(restrictinfo->required_relids, &relid))
{
restrictinfo->fromec = true;
distribute_restrictinfo_to_rels(root, restrictinfo);
}
return;
}
/* EC rejected it, so set left_ec/right_ec the hard way ... */
if (restrictinfo->mergeopfamilies) /* EC might have changed this */
initialize_mergeclause_eclasses(root, restrictinfo);
/* ... and fall through to distribute_restrictinfo_to_rels */
}
-----------------------------------------------------------------------------------
Above the codes, check the condition again when invoked process_equivalence failed,
but it's already under the positive condition "if (restrictinfo->mergeopfamilies)".
It's necessary ?
bigbro_wq@hotmail.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Alias of VALUES RTE in explain plan
Next
From: feichanghong
Date:
Subject: Re: Improve the efficiency of _bt_killitems.