Re: Repeat the condition check twice in function distribute_qual_to_rels - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Repeat the condition check twice in function distribute_qual_to_rels
Date
Msg-id 2447691.1730660822@sss.pgh.pa.us
Whole thread Raw
In response to Repeat the condition check twice in function distribute_qual_to_rels  ("bigbro_wq@hotmail.com" <bigbro_wq@hotmail.com>)
List pgsql-hackers
"bigbro_wq@hotmail.com" <bigbro_wq@hotmail.com> writes:
> I notice that check the condtion again when after invoked process_equivalence and return failed.

>     /* EC rejected it, so set left_ec/right_ec the hard way ... */
>     if (restrictinfo->mergeopfamilies) /* EC might have changed this */

> Above the codes, check the condition again when invoked process_equivalence failed,
> but it's already under the positive condition "if (restrictinfo->mergeopfamilies)".
> It's necessary ?

Yes.  See commit 8ec5429e2: the restrictinfo might now be
completely different from what it was.

(You could have discovered this for yourself by removing
the test and seeing what happened.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: EphemeralNamedRelation and materialized view
Next
From: Daniel Gustafsson
Date:
Subject: Re: Time to add a Git .mailmap?