RE: Skip partition tuple routing with constant partition key - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: Skip partition tuple routing with constant partition key
Date
Msg-id TYAPR01MB2990FF6E73FA8D09C78C6B96FE269@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: Skip partition tuple routing with constant partition key  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses RE: Skip partition tuple routing with constant partition key
List pgsql-hackers
From: houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com>
> I think this patch can solve the performance degradation of key expression after
> applying the [Save the last partition] patch.
> Besides, this could be a separate patch which can improve some more cases.
> Thoughts ?

Thank you for proposing an impressive improvement so quickly!  Yes, I'm in the mood for adopting Amit-san's patch as a
basebecause it's compact and readable, and plus add this patch of yours to complement the partition key function case.
 

But ...

* Applying your patch alone produced a compilation error.  I'm sorry I mistakenly deleted the compile log, but it said
somethinglike "There's a redeclaration of PartKeyContext in partcache.h; the original definition is in partdef.h"
 

* Hmm, this may be too much to expect, but I wonder if we can make the patch more compact...


Regards
Takayuki Tsunakawa


pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Next
From: Masahiko Sawada
Date:
Subject: Re: Performance degradation of REFRESH MATERIALIZED VIEW