RE: POC: postgres_fdw insert batching - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: POC: postgres_fdw insert batching
Date
Msg-id TYAPR01MB2990DB767E314A72A063EA32FEA10@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: POC: postgres_fdw insert batching  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: POC: postgres_fdw insert batching  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
> Right. But I think Tom is right this should initialize ri_BatchSize for all the
> resultRelInfo elements, not just the first one. Per the attached patch, which
> resolves the issue both on x86_64 and armv7l for me.

I think Your patch is perfect in the sense that it's ready for the future multi-target DML support.  +1

Just for learning, could anyone tell me what this loop for?  I thought current Postgres's DML supports a single target
table,so it's enough to handle the first element of mtstate->resultRelInfo.  In that sense, Amit-san and I agreed that
wedon't put the if block in the for loop yet.
 


Regards
Takayuki Tsunakawa


pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: POC: postgres_fdw insert batching
Next
From: Amit Langote
Date:
Subject: Re: POC: postgres_fdw insert batching