RE: libpq debug log - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: libpq debug log
Date
Msg-id TYAPR01MB29902FC694B6B9A3ADB1254AFE7E9@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: libpq debug log  ("alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>)
Responses RE: libpq debug log  ("iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>)
List pgsql-hackers
From: alvherre@alvh.no-ip.org <alvherre@alvh.no-ip.org>
> > Proposed changes on top of v29.
> 
> This last one uses libpq_pipeline -t and verifies the output against an expected
> trace file.  Applies on top of all the previous patches.  I attach the whole lot,
> so that the CF bot has a chance to run it.

Thank you for polishing the patch.

Iwata-san,
Please review Alvaro-san's code, and I think you can integrate all patches into one except for 0002 and 0007.  Those
twopatches may be separate or merged into one as a test patch.
 


> I did notice another problem for comparison of expected trace files, which is
> that RowDescription includes table OIDs for some columns.  I think we would
> need to have a flag to suppress that too, somehow, although the answer to what
> should we do is not as clear as for the other two cases.

I'm afraid this may render the test comparison almost impossible.  Tests that access system catalogs and large objects
probablyoutput OIDs.
 



Regards
Takayuki Tsunakawa



pgsql-hackers by date:

Previous
From: "tsunakawa.takay@fujitsu.com"
Date:
Subject: RE: libpq debug log
Next
From: "Euler Taveira"
Date:
Subject: Re: row filtering for logical replication