RE: libpq debug log - Mailing list pgsql-hackers

From iwata.aya@fujitsu.com
Subject RE: libpq debug log
Date
Msg-id TY2PR01MB4812755B96F72CF50978695DEA760@TY2PR01MB4812.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: libpq debug log  (Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>)
Responses Re: libpq debug log  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello,

Thank you for your review.
I update patch. Please find attached my patch.


> > 2019-04-04 02:39:51.488 UTC  > Query 59 "SELECT
> pg_catalog.set_config('search_path', '', false)"
> 
> The "59" there seems quite odd, though.
Could you explain more detail about this?

"59" is length of protocol message contents. (It does not contain first 1 byte.) 
This order is based on the message format.
https://www.postgresql.org/docs/current/protocol-message-formats.html


> * What is this in pg_conn?  I don't understand why this array is of size
>   MAXPGPATH.
> +    PGFrontendLogMsgEntry frontend_entry[MAXPGPATH];
>   This seems to make pg_conn much larger than we'd like.
Sure. I remove this and change code to use list.

> Minor review points:
I accept all these review points.

Regards,
Aya Iwata

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Block level parallel vacuum