Re: CLUSTER patch and regression test - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: CLUSTER patch and regression test
Date
Msg-id Pine.LNX.4.44.0208080214140.11866-400000@cm-lcon1-46-187.cm.vtr.net
Whole thread Raw
In response to Re: CLUSTER patch and regression test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: CLUSTER patch and regression test  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: CLUSTER patch and regression test  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Tom Lane dijo:

> Looks like Alvaro got sideswiped by the system catalog indexing changes
> I made over the weekend.  It's a simple change, just reduce the whole
> mess to a "CatalogUpdateIndexes()" call.

I update two tuples, so I manually CatalogOpenIndexes() and
CatalogIndexInsert() two times, as per comments in
CatalogUpdateIndexes().

I also removed a couple of useless CommandCounterIncrement(), some
useless definitions in src/include/commands/cluster.h and useless
includes in src/backend/commands/cluster.c.  This version passes the
regression test I had made for previous versions.

If it applies cleanly, please apply :-)

--
Alvaro Herrera (<alvherre[a]atentus.com>)
La web junta la gente porque no importa que clase de mutante sexual seas,
tienes millones de posibles parejas. Pon "buscar gente que tengan sexo con
ciervos incendiánse", y el computador dirá "especifique el tipo de ciervo"
(Jason Alexander)

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: stand-alone composite types patch (was [HACKERS] Proposal: stand-alone composite types)
Next
From: Pierre-Yves LANDURE
Date:
Subject: Re: Polygon contrib