Re: CLUSTER patch and regression test - Mailing list pgsql-patches

From Tom Lane
Subject Re: CLUSTER patch and regression test
Date
Msg-id 28436.1028772257@sss.pgh.pa.us
Whole thread Raw
In response to Re: CLUSTER patch and regression test  (Neil Conway <nconway@klamath.dyndns.org>)
Responses Re: CLUSTER patch and regression test
List pgsql-patches
Neil Conway <nconway@klamath.dyndns.org> writes:
> Alvaro Herrera <alvherre@atentus.com> writes:
>> I sent the CLUSTER patch a few days ago and I think it was missed.  I
>> append it again, this time including the regression test files.

> Applying the patch to current CVS and compiling produces:

> gcc -g3 -O0 -DPS_USE_NONE -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../src/include   -c -o cluster.o
cluster.c-MMD 
> cluster.c: In function `swap_relfilenodes':
> cluster.c:383: `Num_pg_class_indices' undeclared (first use in this function)
> cluster.c:383: (Each undeclared identifier is reported only once
> cluster.c:383: for each function it appears in.)
> cluster.c:432: warning: implicit declaration of function `CatalogOpenIndices'

Looks like Alvaro got sideswiped by the system catalog indexing changes
I made over the weekend.  It's a simple change, just reduce the whole
mess to a "CatalogUpdateIndexes()" call.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: improve SET CONSTRAINTS
Next
From: Tom Lane
Date:
Subject: Re: improve SET CONSTRAINTS