The getTypeInfo patch uses functionality not in Java 1.1 so it cannot be
used in the jdbc1 package.
The JDBC 3 additions look reasonable.
The getMaxTableNameLength patch is not a good idea. You're changing
something general to fix a very specific problem. I would recomend using
explicit constraint names or petitioning backend developers to create
non-conflicating auto generated names.
The toString patch is good. I have changed it to return "" instead of
super.toString() which I believe is a more reasonable value. I have also
fixed a problem with printing PreparedStatements with some parameters not
set. Attached is a test case and the new patch.
Kris Jurka
On Mon, 3 Feb 2003, Oliver Jowett wrote:
> Is there any interest in these patches? Should I resend them elsewhere?
>
> -O
>
> ----- Forwarded message from Oliver Jowett <oliver@opencloud.com> -----
>
> Date: Tue, 17 Dec 2002 19:01:33 +1300
> To: pgsql-jdbc@postgresql.org
> Subject: [JDBC] DatabaseMetaData oddities
> From: Oliver Jowett <oliver@opencloud.com>
>
> These patches fix some oddities in the postgresql JDBC driver's
> implementation of DatabaseMetaData.
>
> The patches are against recent CVS; I've used them against a 7.2.3 server
> and the current CVS (7.4devel) server successfully.
>
> Quick summaries:
>
> pgsql_getTypeInfo-ordering.patch:
> correct ordering of results from DatabaseMetaData.getTypeInfo().
>
> pgsql_more-jdbc3-metadata.patch:
> implement some unimplemented JDBC3 DatabaseMetaData methods.
>
> pgsql_reduce-table-name-length.patch:
> reduce getMaxTableNameLength() by 5 to account for the server
> appending _pkey to generate an index name.
>
> and one non-metadata patch:
>
> pgsql_null-statement-tostring.patch:
> avoid NullPointerException in AbstractJdbc1Statement.toString()
>
> Hopefully these are useful to someone..
>
> -O
>
> [...]
>
> ----- End forwarded message -----
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
>
