Re: pg_dump: use ALTER TABLE for PKs - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_dump: use ALTER TABLE for PKs
Date
Msg-id Pine.LNX.4.30.0202182242050.684-100000@peter.localdomain
Whole thread Raw
In response to pg_dump: use ALTER TABLE for PKs  (Neil Conway <nconway@klamath.dyndns.org>)
Responses Re: pg_dump: use ALTER TABLE for PKs
List pgsql-hackers
Neil Conway writes:

> I've attached a patch which enhances pg_dump to use ALTER TABLE when
> defining the primary keys of a table (instead of including this
> information in the table definition).

I think you've got the "7.2 or later" theme in your patch mixed up.  The
version number you're evaluating is the version of the database you're
dumping.  The feature you're adding is dependent on the version of the
database you're restoring into.  The version of the database you're
restoring into is always >= the pg_dump version.  Thus, you don't need any
version checks.  Plus, I think this patch is going into 7.3, no?

-- 
Peter Eisentraut   peter_e@gmx.net



pgsql-hackers by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: pg_dump: use ALTER TABLE for PKs
Next
From: "Christopher Kings-Lynne"
Date:
Subject: Re: pg_dump: use ALTER TABLE for PKs