Re: pg_dump: use ALTER TABLE for PKs - Mailing list pgsql-hackers

From Neil Conway
Subject Re: pg_dump: use ALTER TABLE for PKs
Date
Msg-id 1014092105.372.42.camel@jiro
Whole thread Raw
In response to Re: pg_dump: use ALTER TABLE for PKs  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pg_dump: use ALTER TABLE for PKs  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
On Mon, 2002-02-18 at 22:46, Peter Eisentraut wrote:
> Neil Conway writes:
>
> > I've attached a patch which enhances pg_dump to use ALTER TABLE when
> > defining the primary keys of a table (instead of including this
> > information in the table definition).
>
> I think you've got the "7.2 or later" theme in your patch mixed up.  The
> version number you're evaluating is the version of the database you're
> dumping.  The feature you're adding is dependent on the version of the
> database you're restoring into.  The version of the database you're
> restoring into is always >= the pg_dump version.  Thus, you don't need any
> version checks.

You're absolutely correct -- thanks for spotting that. A new version of
the patch is attached.

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC

Attachment

pgsql-hackers by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: pg_dump: use ALTER TABLE for PKs
Next
From: Thomas Lockhart
Date:
Subject: Re: Ready to branch 7.2/7.3 ?