[PATCH] Change slash to backslash in make.bat - Mailing list pgadmin-hackers

From zhangjie2@fujitsu.com
Subject [PATCH] Change slash to backslash in make.bat
Date
Msg-id OSZPR01MB8564ABE286FC2A5CC67DFFACF9359@OSZPR01MB8564.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: [PATCH] Change slash to backslash in make.bat
List pgadmin-hackers
Hi, all

In windows, backslash should be used in the path. 
In Linux, slash should be used in path.
But in pgadmin4\make.bat, slash is used in the path.

------------------------------------------------------------------------------------------------------------------------------------------------
FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "print('%APP_NAME%'.lower().replace(' ', ''))"')
DOSET APP_SHORTNAME=%%G
 

FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"')
DOSET PYTHON_MAJOR=%%G
 
FOR /f "tokens=2 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"')
DOSET PYTHON_MINOR=%%G
 
FOR /f "tokens=3 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"')
DOSET PYTHON_REVISION=%%G
 

--------------------------------------------------------------------------------------------------------------------------------------------------
Although the slash does not affect the compilation, I think it is better to modify it.

Here is a patch for make.bat.
Please review.

Best Regards!
Zhang Jie

Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Rename the menu 'Disconnect Database' to 'Disconnect
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added comments column for the functions collection no