Re: [PATCH] Change slash to backslash in make.bat - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [PATCH] Change slash to backslash in make.bat
Date
Msg-id CAM9w-_mDGd4+tZUY7o6+pf55XWQp_EgXHf-kpsMp5ftU-vG6dA@mail.gmail.com
Whole thread Raw
In response to [PATCH] Change slash to backslash in make.bat  ("zhangjie2@fujitsu.com" <zhangjie2@fujitsu.com>)
List pgadmin-hackers
Hi Zhang,

Thank you for the contribution.
Backslashes can have different meanings sometimes and changing the build scripts which are working since long are not needed.
So we can skip this patch.

On Wed, Feb 16, 2022 at 9:01 AM zhangjie2@fujitsu.com <zhangjie2@fujitsu.com> wrote:
Hi, all

In windows, backslash should be used in the path.
In Linux, slash should be used in path.
But in pgadmin4\make.bat, slash is used in the path.
------------------------------------------------------------------------------------------------------------------------------------------------
FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "print('%APP_NAME%'.lower().replace(' ', ''))"') DO SET APP_SHORTNAME=%%G

FOR /f "tokens=1 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MAJOR=%%G
FOR /f "tokens=2 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_MINOR=%%G
FOR /f "tokens=3 DELims=." %%G IN ('%PGADMIN_PYTHON_DIR%/python.exe -c "import sys; print(sys.version.split(' ')[0])"') DO SET PYTHON_REVISION=%%G
--------------------------------------------------------------------------------------------------------------------------------------------------
Although the slash does not affect the compilation, I think it is better to modify it.

Here is a patch for make.bat.
Please review.

Best Regards!
Zhang Jie


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - Cloud Deployment Fixes
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Update the release date in the release notes. Fixes #