Update comments in multixact.c - Mailing list pgsql-hackers

From shiy.fnst@fujitsu.com
Subject Update comments in multixact.c
Date
Msg-id OSZPR01MB631066BF246F8F74E83222FCFDC69@OSZPR01MB6310.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: Update comments in multixact.c
List pgsql-hackers
Hi,

I noticed that commit 5212d447fa updated some comments in multixact.c because
SLRU truncation for multixacts is performed during VACUUM, instead of
checkpoint. Should the following comments which mentioned checkpointer be
changed, too?

1.
* we compute it (using nextMXact if none are valid).  Each backend is
* required not to attempt to access any SLRU data for MultiXactIds older
* than its own OldestVisibleMXactId[] setting; this is necessary because
* the checkpointer could truncate away such data at any instant.

2.
 * We set the OldestVisibleMXactId for a given transaction the first time
 * it's going to inspect any MultiXactId.  Once we have set this, we are
 * guaranteed that the checkpointer won't truncate off SLRU data for
 * MultiXactIds at or after our OldestVisibleMXactId.

Regards,
Shi yu



pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Cross-partition UPDATE and foreign table partitions
Next
From: Laurenz Albe
Date:
Subject: Re: minor bug