Re: [PATCH] SVE popcount support - Mailing list pgsql-hackers

From Chiranmoy.Bhattacharya@fujitsu.com"
Subject Re: [PATCH] SVE popcount support
Date
Msg-id OSBPR01MB266482AB53FDF8638015607D97C52@OSBPR01MB2664.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [PATCH] SVE popcount support  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
> Hm.  Any idea why that is?  I wonder if the compiler isn't using as many
> SVE registers as it could for this.

Not sure, we tried forcing loop unrolling using the below line in the MakeFile
but the results are the same.

pg_popcount_sve.o: CFLAGS += ${CFLAGS_UNROLL_LOOPS} -march=native


> I've also noticed that the latest patch doesn't compile on my M3 macOS
> machine.  After a quick glance, I think the problem is that the
> TRY_POPCNT_FAST macro is set, so it's trying to compile the assembly
> versions.

Fixed, we tried using the existing "choose" logic guarded by TRY_POPCNT_FAST.
The latest patch bypasses TRY_POPCNT_FAST by having a separate choose logic
for aarch64. 


-Chiranmoy
Attachment

pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: new commitfest transition guidance
Next
From: Alexander Korotkov
Date:
Subject: Re: Improve statistics estimation considering GROUP-BY as a 'uniqueiser'