[Doc] Tiny fix for regression tests example - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject [Doc] Tiny fix for regression tests example
Date
Msg-id OS0PR01MB6113954B883ACEB2DDC973F2FBE59@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: [Doc] Tiny fix for regression tests example
List pgsql-hackers

Hi

 

When reading PG DOC, found some example code not correct as it said.

https://www.postgresql.org/docs/devel/regress-run.html

 

Here's a tiny fix in regress.sgml.

 

-make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"

+make check PGOPTIONS="-c geqo=off -c work_mem=50MB"

 

log_checkpoints couldn't be set in PGOPTIONS.

Replace log_checkpoints with geqo in the example code.

 

-make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"

+make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"

 

User needs to specify $(pwd) to let the command execute as expected.

 

The above example code is added by Peter in PG14. So I think we need to apply this fix at PG14/master.

I proposed this fix at pgsql-docs@lists.postgresql.org at [1]. But no reply except Craig. So I please allow me to post the patch at Hackers mail list again in case the fix is missed.

 

[1] https://www.postgresql.org/message-id/OS0PR01MB6113FA937648B8F7A372359BFB009%40OS0PR01MB6113.jpnprd01.prod.outlook.com

 

Regards,

Tang

 

Attachment

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump
Next
From: Fabien COELHO
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option