RE: fix a comment - Mailing list pgsql-hackers

From wangyukun@fujitsu.com
Subject RE: fix a comment
Date
Msg-id OS0PR01MB6003E518D8B42A156DB57F53B4459@OS0PR01MB6003.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: fix a comment  (Amul Sul <sulamul@gmail.com>)
Responses Re: fix a comment
List pgsql-hackers
Hi, Amul

Thank you for reviewing.

> How about simply removing these numbering?

Agree. Please see the v2 patch which delete the number in comment.

Best wishes
Yukun Wang

-----Original Message-----
From: Amul Sul <sulamul@gmail.com> 
Sent: Friday, April 23, 2021 3:51 PM
To: Wang, Yukun/王 俞坤 <wangyukun@fujitsu.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fix a comment

On Fri, Apr 23, 2021 at 12:12 PM wangyukun@fujitsu.com <wangyukun@fujitsu.com> wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> > * Third, search through the result relations that were created 
> > during
> > * tuple routing, if any.
> > */
>
> But the 'Second' was deleted since commit 1375422c78.
>
> Update the 'Third' to 'Second', please see the attachment.
>
> Thoughts?
>

Well yes, looks good to me.

How about simply removing these numbering?

Regards,
Amul

Attachment

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
Next
From: Fujii Masao
Date:
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?