RE: Add Nullif case for eval_const_expressions_mutator - Mailing list pgsql-hackers

From houzj.fnst@fujitsu.com
Subject RE: Add Nullif case for eval_const_expressions_mutator
Date
Msg-id OS0PR01MB571671733EA40F95FF45169D94639@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Add Nullif case for eval_const_expressions_mutator  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add Nullif case for eval_const_expressions_mutator  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
> +                if (!has_nonconst_input)
> +                    return ece_evaluate_expr(expr);
>
> That's not okay without a further check to see if the comparison function used
> by the node is immutable.  Compare ScalarArrayOpExpr, for instance.

Thanks for pointing it out.
Attaching new patch with this change.

Best regards,
houzj

Attachment

pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: [HACKERS] logical decoding of two-phase transactions
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: fix typo in reorderbuffer.c