Re: Add Nullif case for eval_const_expressions_mutator - Mailing list pgsql-hackers

David Steele <david@pgmasters.net> writes:
> Peter, thoughts on the new patch in [1]?

I'm not Peter, but I have a complaint about this bit:

+                if (!has_nonconst_input)
+                    return ece_evaluate_expr(expr);

That's not okay without a further check to see if the comparison function
used by the node is immutable.  Compare ScalarArrayOpExpr, for instance.

            regards, tom lane