On Monday, October 28, 2024 1:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Hou-San, here are a few trivial comments remaining for patch v6-0001.
Thanks for the comments!
>
> ======
> doc/src/sgml/protocol.sgml
>
> 3.
> + <term>Primary status update (B)</term>
> + <listitem>
> + <variablelist>
> + <varlistentry>
> + <term>Byte1('s')</term>
>
> Currently, there are identifiers 's' for the "Primary status update"
> message, and 'S' for the "Primary status request" message.
>
> As mentioned in the previous review ([1] #5b) I preferred it to be the other way
> around:
> 'S' = status from primary
> 's' = request status from primary
>
> Of course, it doesn't make any difference, but "S" seems more important than
> "s", so therefore "S" being the main msg and coming from the *primary*
> seemed more natural to me.
I am not sure if one message is more important than another, so I prefer to
keep the current style. Since this is a minor issue, we can easily revise it in
future version patches if we receive additional feedback.
Other comments look good to me and will address in V7 patch set.
Best Regards,
Hou zj
