Re: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

Hi Vignesh,

Here are my review comments for the v47-0002 (DOCS) patch.

======
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 577bcb4b71..a13f19bdbe 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -517,7 +517,8 @@ CREATE TABLE people (
       Generated columns are allowed to be replicated during logical replication
       according to the <command>CREATE PUBLICATION</command> option
       <link linkend="sql-createpublication-params-with-publish-generated-columns">
-      <literal>include_generated_columns</literal></link>.
+      <literal>include_generated_columns</literal></link>. See
+      <xref linkend="logical-replication-gencols"/> for details.
      </para>
     </listitem>
    </itemizedlist>

Previously (in v1-0002) above there was a link to the new gencols
section ("See XXX for details"), but in v47 that link is no longer
included. Why not?

======
doc/src/sgml/ref/create_publication.sgml

-      lists.
+      lists. See <xref linkend="logical-replication-gencols-howto"/> for more
+      information on the logical replication of generated columns using a
+      column list publication.
      </para>

I don't really think this change is necessary.

The existing paragraph already says "When a column list is specified,
only the named columns are replicated.", so there is nothing special
more than that which we really need to say for generated columns.

Also, this paragraph already has a link to the "Column List" chapter
for more details, so if the user really wants to learn about column
lists which happen to have generated columns in them, then that's
where they should look. and there is a link to the new chapter 29.6
from there.

======
Kind Regards,
Peter Smith.
Fujitsu Australia