RE: pg_publication_tables show dropped columns - Mailing list pgsql-hackers

From houzj.fnst@fujitsu.com
Subject RE: pg_publication_tables show dropped columns
Date
Msg-id OS0PR01MB571610CCAB5763BCBC5976E8947E9@OS0PR01MB5716.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: pg_publication_tables show dropped columns  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_publication_tables show dropped columns
List pgsql-hackers
On Tuesday, September 6, 2022 11:13 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Jaime Casanova <jcasanov@systemguards.com.ec> writes:
> > Just trying the new column/row filter on v15, I found this issue that
> > could be replicated very easily.
>
> Bleah.  Post-beta4 catversion bump, here we come.

Oh, Sorry for the miss.

> > This could be solved by adding a "NOT attisdropped", simple patch
> > attached.
>
> That view seems quite inefficient as written --- I wonder if we can't do better by
> nuking the join-to-unnest business and putting the restriction in a WHERE
> clause on the pg_attribute scan.
> The query plan that you get for it right now is certainly awful.

I agree and try to improve the query as suggested.

Here is the new version patch.
I think the query plan and cost looks better after applying the patch.

Best regards,
Hou zj


Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Return value of PathNameOpenFile()
Next
From: John Naylor
Date:
Subject: Re: [RFC] building postgres with meson - v12