Re: Typo in pg_db_role_setting.h - Mailing list pgsql-hackers

From Japin Li
Subject Re: Typo in pg_db_role_setting.h
Date
Msg-id MEYP282MB1669B6F3DBAA06826CC4B52AB69D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Typo in pg_db_role_setting.h  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Tue, 02 Aug 2022 at 15:45, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 2 Aug 2022, at 09:37, Richard Guo <guofenglinux@gmail.com> wrote:
>
>> The examples listed upthread all contain such comment in foo.h saying
>> 'prototypes for functions in foo.c'.  For instance, in buffile.h, there is
>> comment saying
>
>> /*
>>  * prototypes for functions in buffile.c
>>  */
>> 
>> So if we remove such comments, should we also do so for those cases?
>
> Comments which state the obvious are seldom helpful, I would prefer to remove
> such comments and only explicitly call out the .c file in a comment when it's a
> different basename from the header.

+1

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Typo in pg_db_role_setting.h
Next
From: Zhang Mingli
Date:
Subject: Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO