Postgres Pro
Downloads
Home   >   mailing lists

Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
Date
Msg-id cdf7a67c-3f5e-4ce7-86db-151f86e27d8a@Spark
Whole thread Raw
In response to Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
List pgsql-hackers
Tree view

Regards,
Zhang Mingli
On Aug 2, 2022, 12:30 +0800, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, wrote:
An empty List is not NULL but NIL (which values are identical,
though). 
Thanks for pointing that out. Fix it in new patch.
There are some other option combinations that are rejected
by ProcessCopyOptions. On the other hand *re*checking all
combinations that the function should have rejected is kind of silly.
Addition to that, I doubt the assertions are really needed even though
the wrong values don't lead to any serious consequence.

Agree. 
ProcessCopyOptions has rejected all invalid combinations and assertions are optional.
regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: Typo in pg_db_role_setting.h
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: COPY TO (FREEZE)?