Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW - Mailing list pgsql-hackers

From japin
Subject Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW
Date
Msg-id MEYP282MB166996BD30E922F182FDC452B6AD0@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
On Sat, 09 Jan 2021 at 09:38, Bharath Rupireddy wrote:
> On Fri, Jan 8, 2021 at 9:50 PM japin <japinli@hotmail.com> wrote:
>> > Attaching v3 patches, please consider these for further review.
>> >
>>
>> I find that both the declaration and definition of match_matview_with_new_data()
>> have a tab between type and variable.  We can use pgindent to fix it.
>> What do you think?
>>
>>
>> static void
>> match_matview_with_new_data(RefreshMatViewStmt *stmt, Relation  matviewRel,
>>                                                               ^
>>                             Oid matviewOid, Oid OIDNewHeap, Oid relowner,
>>                             int save_sec_context, char relpersistence,
>>                             uint64  processed)
>>                                   ^
>
> I ran pgindent on 0001 patch to fix the above. 0002 patch has no
> changes. If I'm correct, pgindent will be run periodically on master.
>

Thanks for your point out. I don't know before.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Improper use about DatumGetInt32
Next
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Simple progress reporting for COPY command