Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW
Date
Msg-id CALj2ACXTQzEVhCO_dQ0JDPj=_vKf5NsSvLrPa9J1P13FiPEtwA@mail.gmail.com
Whole thread Raw
In response to Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW  (japin <japinli@hotmail.com>)
Responses Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW  (japin <japinli@hotmail.com>)
List pgsql-hackers
On Fri, Jan 8, 2021 at 9:50 PM japin <japinli@hotmail.com> wrote:
> > Attaching v3 patches, please consider these for further review.
> >
>
> I find that both the declaration and definition of match_matview_with_new_data()
> have a tab between type and variable.  We can use pgindent to fix it.
> What do you think?
>
>
> static void
> match_matview_with_new_data(RefreshMatViewStmt *stmt, Relation  matviewRel,
>                                                               ^
>                             Oid matviewOid, Oid OIDNewHeap, Oid relowner,
>                             int save_sec_context, char relpersistence,
>                             uint64  processed)
>                                   ^

I ran pgindent on 0001 patch to fix the above. 0002 patch has no
changes. If I'm correct, pgindent will be run periodically on master.

Attaching v4 patch set for further review.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Next
From: Michael Paquier
Date:
Subject: Re: Improper use about DatumGetInt32