On Thu, 04 Jul 2024 at 17:17, Richard Guo <guofenglinux@gmail.com> wrote:
> On Fri, Jun 28, 2024 at 3:21 PM Richard Guo <guofenglinux@gmail.com> wrote:
>> On Fri, Jun 28, 2024 at 2:54 PM Richard Guo <guofenglinux@gmail.com> wrote:
>> > I've refined this test case further to make it more stable by using an
>> > additional filter 'a.tenthous < 5000'. Besides, I noticed a surplus
>> > blank line in ExecHashJoinImpl(). I've removed it in the v7 patch.
>>
>> BTW, I've also verified the empty-rel optimization for hash join and
>> AFAICT it works correctly for the new right-semi join.
>
> Here is a new rebase.
>
> Barring objections, I'm planning to push it soon.
>
Thanks for updating the patch. It looks good to me, except for a minor nitpick:
s/right-semijoin/right-semi join/
--
Regrads,
Japin Li