On Jul 4, 2024, at 04:28, jian he <jian.universality@gmail.com> wrote:
> Do you need to reset the datestyle?
Wouldn’t hurt but it’s not necessary, no. It’s set only for the execution of this file, and there are no more calls
thatrely on it.
> also the above query is time zone sensitive, maybe the time zone is
> set in another place, but that's not explicit?
It’s implicit in how PostgreSQL runs its test suite; other tests later change it.
> <para>
> - String value converted from a JSON boolean, number, string, or datetime
> + String value converted from a JSON boolean, number, string, or
> + datetime. Note that the string output of datetimes is determined by
> + the <xref linkend="guc-datestyle"/> parameter.
> </para>
> imho, your patch has just too many examples.
I’m confused. There are no examples in my patch, or this bit you cite.
> for explaining the above sentence, the following example should be enough.
Are you referring to the tests? I made them comprehensive so that we reliably demonstrate the behavior of the string()
methodon all the date/time data types. They are not examples, not in the documentation sense at least.
Best,
David
