Maybe we can remove the type cast in typecache.c - Mailing list pgsql-hackers

From qinghao huang
Subject Maybe we can remove the type cast in typecache.c
Date
Msg-id ME3P282MB20515B5E0AB952E280DA7A4FA1AC9@ME3P282MB2051.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
Responses Re: Maybe we can remove the type cast in typecache.c
List pgsql-hackers
Hi hackers,
    When I was reading postgres code, I found there is a wierd type cast. I'm pondering if it is necessary.

```
    /* Allocate a new typmod number.  This will be wasted if we error out. */
    typmod = (int)
        pg_atomic_fetch_add_u32(&CurrentSession->shared_typmod_registry->next_typmod,
                                1);

```
    typmod has u32 type, but we cast it to int first.

    And I also have some confusion about why `NextRecordTypmod` and `TupleDescData.tdtypmod` has type of int32, but `SharedTypmodTableEntry.typmod` has type of uint32.

Best regard,
Qinghao Huang

pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Track IO times in pg_stat_io
Next
From: Kartyshov Ivan
Date:
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed