Re: Maybe we can remove the type cast in typecache.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Maybe we can remove the type cast in typecache.c
Date
Msg-id 746093.1677598539@sss.pgh.pa.us
Whole thread Raw
In response to Maybe we can remove the type cast in typecache.c  (qinghao huang <wfnuser@hotmail.com>)
List pgsql-hackers
qinghao huang <wfnuser@hotmail.com> writes:
>     When I was reading postgres code, I found there is a wierd type cast. I'm pondering if it is necessary.

> ```
>     /* Allocate a new typmod number.  This will be wasted if we error out. */
>     typmod = (int)
>         pg_atomic_fetch_add_u32(&CurrentSession->shared_typmod_registry->next_typmod,
>                                 1);

> ```
>     typmod has u32 type, but we cast it to int first.

typmods really ought to be int32, not uint32, so IMO none of this is
exactly right.  But it's also true that it makes no real difference.
Postgres pretty much assumes that "int" is 32 bits.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler()
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)