Re: fd.c: flush data problems on osx - Mailing list pgsql-hackers

From Stas Kelvich
Subject Re: fd.c: flush data problems on osx
Date
Msg-id FF9F0CF0-B2C9-46B4-8338-4A1593A55146@postgrespro.ru
Whole thread Raw
In response to Re: fd.c: flush data problems on osx  (Andres Freund <andres@anarazel.de>)
Responses Re: fd.c: flush data problems on osx
Re: fd.c: flush data problems on osx
List pgsql-hackers
On 21 Mar 2016, at 14:53, Andres Freund <andres@anarazel.de> wrote:
> Hm. I think we should rather just skip calling pg_flush_data in the
> directory case, that very likely isn't beneficial on any OS.

Seems reasonable, changed.

> I think we still need to fix the mmap() implementation to support the
> offset = 0, nbytes = 0 case (via fseek(SEEK_END).

It is already in this diff. I’ve added this few messages ago.


---
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Relation extension scalability
Next
From: Petr Jelinek
Date:
Subject: Re: Applying logical replication changes by more than one process