On Mon, Mar 21, 2016 at 9:09 PM, Stas Kelvich <s.kelvich@postgrespro.ru> wrote:
> On 21 Mar 2016, at 14:53, Andres Freund <andres@anarazel.de> wrote:
>> Hm. I think we should rather just skip calling pg_flush_data in the
>> directory case, that very likely isn't beneficial on any OS.
>
> Seems reasonable, changed.
>
>> I think we still need to fix the mmap() implementation to support the
>> offset = 0, nbytes = 0 case (via fseek(SEEK_END).
>
> It is already in this diff. I’ve added this few messages ago.
A similar change seems to be needed in initdb.c's pre_sync_fname.
--
Michael
