RE: Duplicate constraint names in 7.0.3 - Mailing list pgsql-hackers

DOH!

I installed bison and there is a tiny little compile-stopper.  Use the
attached diff instead.

(I forgot to declare 'i' :) )

Chris

> -----Original Message-----
> From: pgsql-hackers-owner@postgresql.org
> [mailto:pgsql-hackers-owner@postgresql.org]On Behalf Of Christopher
> Kings-Lynne
> Sent: Tuesday, 8 May 2001 1:12 PM
> To: Hackers
> Cc: pgman@candle.pha.pa.us
> Subject: RE: [HACKERS] Duplicate constraint names in 7.0.3
>
>
> Assuming that generating a context diff is a matter of going 'cvs diff -c
> heap.c' then attached is a context diff.
>
> To jog people's memories, it's intended to fix the problem with the
> following code creating duplicate constraint names:
>
> CREATE TABLE "test" (
>    "a" int4,
>    CHECK (a < 400),
>    CONSTRAINT "$1" CHECK (a > 5)
> );
>
> Chris
>
> > -----Original Message-----
> > From: pgsql-hackers-owner@postgresql.org
> > [mailto:pgsql-hackers-owner@postgresql.org]On Behalf Of Bruce Momjian
> > Sent: Tuesday, 8 May 2001 12:42 PM
> > To: Christopher Kings-Lynne
> > Cc: Hackers
> > Subject: Re: [HACKERS] Duplicate constraint names in 7.0.3
> >
> >
> >
> > Can you send a context diff please?  Thanks.
> >
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > OK,
> > >
> > > I have modifed heap.c so that it won't automatically generate
> duplicate
> > > constraint names.
> > >
> > > I have _not_ compiled this yet, as it's a bit of a pain for me
> > cos I don't
> > > have bison, etc.  However, it looks good to me, and if someone
> > else wants to
> > > test it and then maybe think about if the patch is necessary
> > that's fine by
> > > me.
> > >
> > > If no-one wants to test it, I will eventually get around to testing it
> > > myself.
> > >
> > > Given that this is my first code patch for Postgres - I should
> > treat it with
> > > caution!
> > >
> > > Chris
> > >
> > > > -----Original Message-----
> > > > From: pgsql-hackers-owner@postgresql.org
> > > > [mailto:pgsql-hackers-owner@postgresql.org]On Behalf Of Christopher
> > > > Kings-Lynne
> > > > Sent: Friday, 4 May 2001 12:33 PM
> > > > To: Hackers
> > > > Subject: RE: [HACKERS] Duplicate constraint names in 7.0.3
> > > >
> > > >
> > > > > A reasonable interpretation of DROP CONSTRAINT "foo" is to
> > drop *all*
> > > > > constraints named "foo" on the target table.
> > > >
> > > > Then it should probably be a good thing to avoid the automatic
> > > > generation of
> > > > duplicate names?  I might take a look at that, actually...
> > > >
> > > > Chris
> > > >
> > > >
> > > > ---------------------------(end of
> > broadcast)---------------------------
> > > > TIP 6: Have you searched our list archives?
> > > >
> > > > http://www.postgresql.org/search.mpl
> > > >
> >
> > [ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of
> broadcast)---------------------------
> > > TIP 2: you can get off all lists at once with the unregister command
> > >     (send "unregister YourEmailAddressHere" to
> majordomo@postgresql.org)
> >
> > --
> >   Bruce Momjian                        |  http://candle.pha.pa.us
> >   pgman@candle.pha.pa.us               |  (610) 853-3000
> >   +  If your life is a hard drive,     |  830 Blythe Avenue
> >   +  Christ can be your backup.        |  Drexel Hill,
> Pennsylvania 19026
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
> >
>