Re: Small documentation improvement for ALTER SUBSCRIPTION - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Small documentation improvement for ALTER SUBSCRIPTION
Date
Msg-id E8FD84DD-3FFE-47E0-84BB-B50149F671E1@yesql.se
Whole thread Raw
In response to Re: Small documentation improvement for ALTER SUBSCRIPTION  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Small documentation improvement for ALTER SUBSCRIPTION
List pgsql-hackers
> On 7 Sep 2021, at 13:36, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> On 12.08.21 04:52, Masahiko Sawada wrote:
>> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>>
>>>> On 11 Aug 2021, at 09:57, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>>
>>>> Additionally, refresh options as described in
>>>> <replaceable>refresh_option</replaceable> of
>>>> <literal>REFRESH PUBLICATION</literal> may be specified,
>>>> except in the case of <literal>DROP PUBLICATION</literal>.
>>>
>>> Since this paragraph is under the literal option “refresh”, which takes a
>>> value, I still find your original patch to be the clearest.
>> Yeah, I prefer my original patch over this idea. On the other hand, I
>> can see the point of review comment on it that Amit pointed out[1].
>
> How about this:
>
> -      Additionally, refresh options as described
> -      under <literal>REFRESH PUBLICATION</literal> may be specified.
> +      Additionally, the options described under <literal>REFRESH
> +      PUBLICATION</literal> may be specified, to control the implicit refresh
> +      operation.

LGTM.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: Non-decimal integer literals
Next
From: Daniel Gustafsson
Date:
Subject: Re: OpenSSL 3.0.0 compatibility