On 16.08.21 17:32, John Naylor wrote: > The one thing that jumped out at me on a cursory reading is > the {integer} rule, which seems to be used nowhere except to > call process_integer_literal, which must then inspect the token text to > figure out what type of integer it is. Maybe consider 4 separate > process_*_literal functions?
Agreed, that can be done in a simpler way. Here is an updated patch.
Hi,
Minor comment:
+SELECT int4 '0o112';
Maybe involve digits of up to 7 in the octal test case.
