Postgres Pro
Downloads
Home   >   mailing lists

Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date
Msg-id E7468EC3-EED5-4737-95CB-CDC7E8B7C91B@yesql.se
Whole thread Raw
In response to Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
List pgsql-hackers
Tree view 
> On 15 Nov 2021, at 19:42, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>
> On 15.11.21 10:38, Bharath Rupireddy wrote:
>>> I still think that the v8 patch posted earlier is the better option, which
>>> increase granularity of error reporting with a small code footprint.
>> Thanks. Attaching the v8 here again.
>
> I find the use of RelationUsesLocalBuffers() confusing in this patch. It would be clearer to check relpersistence
directlyin both branches of the if statement. 

Admittedly it didn't bother me, but the more I think about it the more I agree
with Peter, so +1 on changing.

--
Daniel Gustafsson        https://vmware.com/

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: RecoveryInProgress() has critical side effects
Next
From: Daniel Gustafsson
Date:
Subject: Re: Support for NSS as a libpq TLS backend