Postgres Pro
Downloads
Home   >   mailing lists

Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
Date
Msg-id f79c6631-ca02-6c4a-e70b-17e8bf96cef3@enterprisedb.com
Whole thread Raw
In response to Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Logical Replication - improve error message while adding tables to the publication in check_publication_add_relation
List pgsql-hackers
Tree view 
On 15.11.21 10:38, Bharath Rupireddy wrote:
>> I still think that the v8 patch posted earlier is the better option, which
>> increase granularity of error reporting with a small code footprint.
> Thanks. Attaching the v8 here again.

I find the use of RelationUsesLocalBuffers() confusing in this patch. 
It would be clearer to check relpersistence directly in both branches of 
the if statement.

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [RFC] building postgres with meson
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: Test::More version