Re: pg_dump new feature: exporting functions only. Bad or good idea ? - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_dump new feature: exporting functions only. Bad or good idea ?
Date
Msg-id E3C31209-12DD-4D1F-8B35-E52B2E11B59A@yesql.se
Whole thread Raw
In response to Re: pg_dump new feature: exporting functions only. Bad or good idea ?  (Lætitia Avrot <laetitia.avrot@gmail.com>)
Responses Re: pg_dump new feature: exporting functions only. Bad or good idea ?
List pgsql-hackers
> On 30 Jul 2021, at 12:55, Lætitia Avrot <laetitia.avrot@gmail.com> wrote:
>
> > On Fri, Jul 9, 2021 at 4:43 PM Tomas Vondra <tomas.vondra@enterprisedb.com> wrote:
> >
> > The main question I have is whether this should include procedures. I'd
> > probably argue procedures should be considered different from functions
> > (i.e. requiring a separate --procedures-only option), because it pretty
> > much is meant to be a separate object type. We don't allow calling DROP
> > FUNCTION on a procedure, etc. It'd be silly to introduce an unnecessary
> > ambiguity in pg_dump and have to deal with it sometime later.
>
> I respectfully disagree. In psql, the `\ef` and `\df` metacommands will also list procedures, not just functions.

I tend to agree that we should include both, while they are clearly different I
don't think it would be helpful in this case to distinguish.

Looking at this thread I think it makes sense to go ahead with this patch.  The
filter functionality worked on in another thread is dealing with cherry-picking
certain objects where this is an all-or-nothing switch, so I don't think they
are at odds with each other.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Commitfest 2021-11 Patch Triage - Part 2
Next
From: Daniel Gustafsson
Date:
Subject: Re: An out-of-date comment in nodeIndexonlyscan.c