Re: [PATCH] Print error when libpq-refs-stamp fails - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Print error when libpq-refs-stamp fails
Date
Msg-id E355517C-AA5D-41F5-B4F2-A5534CFD1F48@yesql.se
Whole thread Raw
In response to Re: [PATCH] Print error when libpq-refs-stamp fails  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Print error when libpq-refs-stamp fails  (Rachel Heaton <rachelmheaton@gmail.com>)
List pgsql-hackers
> On 4 Oct 2021, at 19:21, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 4 Oct 2021, at 19:02, Jacob Champion <pchampion@vmware.com> wrote:
>>
>> On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote:
>>>
>>> Could you please confirm that the change from -A to -a in nm arguments
>>> in this patch is intentional?
>>
>> That was not intended by us, thank you for the catch! A stray
>> lowercasing in vim, perhaps.
>
> Hmm, I will take care of this shortly.

Right, so I missed this in reviewing and testing, and I know why the latter
didn't catch it.  nm -A and -a outputs the same thing *for this input* on my
Debian and macOS boxes, with the small difference that -A prefixes the line
with the name of the input file.  -a also include debugger symbols, but for
this usage it didn't alter the results.  I will go ahead and fix this, thanks
for catching it!

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: improvements in Unicode tables generation code
Next
From: Daniel Gustafsson
Date:
Subject: Re: 2021-09 Commitfest