From: Daniel Gustafsson <daniel@yesql.se> Date: Monday, October 4, 2021 at 11:36 AM To: Jacob Champion <pchampion@vmware.com> Cc: Rachel Heaton <rachelmheaton@gmail.com>, pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>, a.voloshin@postgrespro.ru <a.voloshin@postgrespro.ru> Subject: Re: [PATCH] Print error when libpq-refs-stamp fails
> On 4 Oct 2021, at 19:21, Daniel Gustafsson <daniel@yesql.se> wrote: > >> On 4 Oct 2021, at 19:02, Jacob Champion <pchampion@vmware.com> wrote: >> >> On Mon, 2021-10-04 at 23:40 +0700, Anton Voloshin wrote: >>> >>> Could you please confirm that the change from -A to -a in nm arguments >>> in this patch is intentional? >> >> That was not intended by us, thank you for the catch! A stray >> lowercasing in vim, perhaps. > > Hmm, I will take care of this shortly.
Right, so I missed this in reviewing and testing, and I know why the latter didn't catch it. nm -A and -a outputs the same thing *for this input* on my Debian and macOS boxes, with the small difference that -A prefixes the line with the name of the input file. -a also include debugger symbols, but for this usage it didn't alter the results. I will go ahead and fix this, thanks for catching it!
