pgsql: Tighten usage of PSQL_WATCH_PAGER. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Tighten usage of PSQL_WATCH_PAGER.
Date
Msg-id E1pxZ6p-001pGI-Jm@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tighten usage of PSQL_WATCH_PAGER.

Don't use PSQL_WATCH_PAGER when stdin/stdout are not a terminal.
This corresponds to the restrictions on when other commands will
use [PSQL_]PAGER.  There isn't a lot of sense in trying to use a
pager in non-interactive cases, and doing so allows an environment
setting to break our tests.

Also, ignore PSQL_WATCH_PAGER if it is set but empty or all-blank,
for the same reasons we ignore such settings of [PSQL_]PAGER (see
commit 18f8f784c).

No documentation change is really needed, since there is nothing
suggesting that these constraints on [PSQL_]PAGER didn't already
apply to PSQL_WATCH_PAGER too.  But I rearranged the text
a little to make it read more naturally (IMHO anyway).

Per report from Pavel Stehule.  Back-patch to v15 where
PSQL_WATCH_PAGER was introduced.

Discussion: https://postgr.es/m/CAFj8pRDTwFzmEWdA-gdAcUh0ZnxUioSfTMre71WyB_wNJy-8gw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51b2c08798867cb9788090704b37c4698b456240

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml | 31 ++++++++++++++++---------------
src/bin/psql/command.c         | 14 ++++++++++----
2 files changed, 26 insertions(+), 19 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: initdb: Set collversion for standard collation UNICODE
Next
From: Nathan Bossart
Date:
Subject: pgsql: Improve error message for pg_create_subscription.