pgsql: Harmonize reorderbuffer parameter names. - Mailing list pgsql-committers

From Peter Geoghegan
Subject pgsql: Harmonize reorderbuffer parameter names.
Date
Msg-id E1oZi3m-000pD8-Gb@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Harmonize reorderbuffer parameter names.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Harmonize reorderbuffer parameter names.

Make reorderbuffer.h function declarations consistently use named
parameters.  Also make sure that the declarations use names that match
corresponding names from function definitions in reorderbuffer.c.  This
makes the definitions easier to follow, especially in the case of
functions that happen to have adjoining arguments of the same type.

This patch was written with help from clang-tidy.  Specifically, its
"readability-inconsistent-declaration-parameter-name" check and its
"readability-named-parameter" check were used.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/3955318.1663377656@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/035ce1feb2ed27680558ebc5cd1455041c8ec3cf

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c |  6 +--
src/include/replication/reorderbuffer.h         | 72 ++++++++++++++-----------
2 files changed, 43 insertions(+), 35 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Make check_usermap() parameter names consistent.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.