Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Harmonize reorderbuffer parameter names. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Harmonize reorderbuffer parameter names.
Date
Msg-id 92291.1663476459@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Harmonize reorderbuffer parameter names.  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: pgsql: Harmonize reorderbuffer parameter names.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
Tree view 
Peter Geoghegan <pg@bowt.ie> writes:
> Harmonize reorderbuffer parameter names.

I'm confused about this, because it didn't fix the (ahem) poster-child
case?

-extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
-extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
+extern void ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid,
+                                    TransactionId subxid, XLogRecPtr lsn);
+extern void ReorderBufferCommitChild(ReorderBuffer *rb, TransactionId, TransactionId,
                                     XLogRecPtr commit_lsn, XLogRecPtr end_lsn);

ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
short some parameter names.

            regards, tom lane

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Harmonize reorderbuffer parameter names.
Next
From: Peter Geoghegan
Date:
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.