Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Harmonize reorderbuffer parameter names. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Harmonize reorderbuffer parameter names.
Date
Msg-id CAH2-Wz=1Bzwq5Cc-vLa_x-hoA6K+jGd9NmmmSmW9ELp57-cfvg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Harmonize reorderbuffer parameter names.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Harmonize reorderbuffer parameter names.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
Tree view 
On Sat, Sep 17, 2022 at 9:47 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
> short some parameter names.

I actually noticed that clang-tidy missed this one myself, shortly
after commit. I still haven't figured out why, but it seems like it
might be a bug in the readability-named-parameter check. Could also
have something to do with my clang tooling config, even though it
works well overall.

I'll fix this soon, in any case.

-- 
Peter Geoghegan

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
Next
From: Michael Paquier
Date:
Subject: pgsql: Remove unused argument "isSlice" from transformAssignmentSubscri