pgsql: Skip empty transactions for logical replication. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Skip empty transactions for logical replication.
Date
Msg-id E1nZNz3-001zFN-UA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Skip empty transactions for logical replication.

The current logical replication behavior is to send every transaction to
subscriber even if the transaction is empty. This can happen because
transaction doesn't contain changes from the selected publications or all
the changes got filtered. It is a waste of CPU cycles and network
bandwidth to build/transmit these empty transactions.

This patch addresses the above problem by postponing the BEGIN message
until the first change is sent. While processing a COMMIT message, if
there was no other change for that transaction, do not send the COMMIT
message. This allows us to skip sending BEGIN/COMMIT messages for empty
transactions.

When skipping empty transactions in synchronous replication mode, we send
a keepalive message to avoid delaying such transactions.

Author: Ajin Cherian, Hou Zhijie, Euler Taveira
Reviewed-by: Peter Smith, Takamichi Osumi, Shi Yu, Masahiko Sawada, Greg Nancarrow, Vignesh C, Amit Kapila
Discussion: https://postgr.es/m/CAMkU=1yohp9-dv48FLoSPrMqYEyyS5ZWkaZGD41RJr10xiNo_Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5a9d86d8ffcadc52ff3729cd00fbd83bc38643c

Modified Files
--------------
src/backend/replication/logical/logical.c   |   6 +-
src/backend/replication/pgoutput/pgoutput.c | 141 ++++++++++++++++++++++++++--
src/backend/replication/walsender.c         |  72 +++++++++++---
src/include/replication/logical.h           |   3 +-
src/include/replication/output_plugin.h     |   2 +-
src/test/subscription/t/001_rep_changes.pl  |  28 ++++++
src/test/subscription/t/020_messages.pl     |   5 +-
src/tools/pgindent/typedefs.list            |   1 +
8 files changed, 228 insertions(+), 30 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Add function to pump IPC process until string match
Next
From: Michael Paquier
Date:
Subject: pgsql: Add TAP test in pg_dump with --format=tar and --compress